-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cisco ios mac addr-table: fix "Secure" entry and empty dest port #943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_name and native_vlan_name
…ocode#625) * Adds template for show vpn-sessiondb anyconnect * Adds presumptive output of a second user output Co-authored-by: Josh VanDeraa <josh.vanderaa@networktocode.com>
…pace capture in security_group (networktocode#626)
…de#629) Also fixes a typo on ``loacl`` capture group
…otocol, type, network, mask (networktocode#647)
…d by changing it from word to non-whitespace (networktocode#659)
Changed Ciena platform name Created templates for: * chassis show temperature * port show * rstp show * vlan show
…tocode#990) Co-authored-by: Alejandro Hernandez <alejandro.hernandez@toronto.ca>
…e#981) - Add Cienna traffic-profile standard-profile
…code#978) * New template: cisco_nxos_show_ip_interface_vrf_all.textfsm * Update index * Update index
…#975) New template: juniper_junos_show_system_uptime.textfsm
…rktocode#977) As per https://techhub.hpe.com/eginfolib/networking/docs/switches/5940/5200-1008b_fund_cr/content/491962772.htm output of the `display clock` commands output contains date in `MM/DD/YYYY` format. Can confirm this on different types of HPE switches I have at my disposal. Added test cases that cover the scenarios when time zone and daylight time saving configurations are set.
…w-mac-fix-type2 Fix ios_mac-addr type2
@jacdavi Do you mind resolving the conflicts? There have been a few updates to the template that are conflicting with your change now. |
# Conflicts: # ntc_templates/templates/cisco_ios_show_mac-address-table.textfsm # tests/cisco_ios/show_mac-address-table/cisco_ios_show_mac-address-table9.yml
Ok should be good to go. #994 handled rows without a destination port by nature of switching to a list, so now this PR's only real change is to allow "Secure" ( |
pszulczewski
force-pushed
the
master
branch
2 times, most recently
from
April 12, 2023 15:24
131859a
to
3e8cb51
Compare
jmcgill298
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_mac-address-table
,cisco_ios
,show mac address-table
SUMMARY
I found a few cases that were breaking while trying things out for the first time on a handful of different switches.
In particular issues with static ports that had the "Secure" flag or no destination port set.
The changes address those two issues.
It may make sense to allow other values from the address-table legend (see raw output 9), but I haven't seen those so I left that as is.
Instead of adding a new test case, I appended to an existing one of the same format.
The new cases (along with all others) passed locally.
Input (truncated to specific entries):
Before:
"State Error raised. Rule Line: 32. Input Line: S 67 0000.0000.0004 static No - Te1/5/11"
After):
Still learning the ropes of both networking and TextFSM. Feel free to suggest changes.